I have been taking a look into tests for Sanic recent days, and I found there are some files didn’t be exposed in Codecov Report.
When I check the report, it shows that Sanic contains 17 files. But actually, there are 20 files(total 21 files but __main__.py
is omit by .coveragerc). And, the missing files are: sanic/blueprints.py
, sanic/server.py
, sanic/websocket.py
.
For example, @harshanarayana was sending an amazing PR about blueprint groups(thanks to him), this PR actually changes some lines of code in sanic/blueprints.py
. And you can see that Codecov didn’t report sanic/blueprints.py
in Impacted Files.
Furthermore, If there is a new PR only modify those three files, The code coverage will not be changed even there are thousands of code be added.
This might not influence the functionality of Sanic but I still hope that code coverage can be a quality assurance of Sanic. Let me know your thoughts.